Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce Get and WithPropertiesExt #15632

Merged
merged 2 commits into from
Mar 12, 2024
Merged

refactor: introduce Get and WithPropertiesExt #15632

merged 2 commits into from
Mar 12, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Mar 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@tabVersion
Copy link
Contributor

any background info?

@xxchan Graphite App
Copy link
Member Author

xxchan commented Mar 12, 2024

any background info?

Simplify code. is_xx_btreemap + is_xx_hashmap don't make sense

tabVersion
tabVersion approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the refactor.

@xxchan Graphite App
Copy link
Member Author

xxchan commented Mar 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan mentioned this pull request Mar 12, 2024
Merged
9 tasks
@xxchan Graphite App
Copy link
Member Author

xxchan commented Mar 12, 2024

Merge activity

  • Mar 12, 4:35 PM GMT+8: Graphite failed to merge this pull request due to This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite. Try your merge again, or report a bug if you see this consistently.

@xxchan xxchan added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit d527ba8 Mar 12, 2024
27 of 28 checks passed
@xxchan xxchan deleted the xxchan/fixed-xerinae branch March 12, 2024 09:12
@xxchan xxchan mentioned this pull request Mar 12, 2024
Merged
11 tasks
jetjinser pushed a commit that referenced this pull request Mar 14, 2024
@xxchan @jetjinser
refactor: introduce Get and WithPropertiesExt (#15632)
a3d58ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@tabVersion tabVersion tabVersion approved these changes

Assignees
No one assigned
Labels
type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxchan @tabVersion @BugenZhao